goldmedal commented on issue #14652: URL: https://github.com/apache/datafusion/issues/14652#issuecomment-2663631166
> Just FYI: As I note in [#14729](https://github.com/apache/datafusion/issues/14729), it seems rust (neither compile nor clippy) doesn't warn about _implementing_ a deprecated method, only _calling_ it. As such, the eventual removal of `invoke_batch` will be a sudden compile-time break for anyone who's not manually checking changelogs. > The deprecated flag of `invoke_batch` was removed by https://github.com/apache/datafusion/pull/13491#discussion_r1853902300. I'm not sure why we removed it 🤔. But I think we should add it back after all the sub-issues are done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
