skyzh commented on code in PR #14595: URL: https://github.com/apache/datafusion/pull/14595#discussion_r1957439224
########## datafusion/optimizer/src/decorrelate_lateral_join.rs: ########## @@ -0,0 +1,106 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! [`DecorrelateLateralJoin`] decorrelates logical plans produced by lateral joins. + +use crate::optimizer::ApplyOrder; +use crate::{decorrelate_predicate_subquery, OptimizerConfig, OptimizerRule}; + +use datafusion_common::tree_node::{Transformed, TreeNodeRecursion, TreeNodeVisitor}; +use datafusion_common::Result; +use datafusion_expr::logical_plan::JoinType; +use datafusion_expr::LogicalPlan; + +/// Optimizer rule for rewriting lateral joins to joins +#[derive(Default, Debug)] +pub struct DecorrelateLateralJoin {} + +impl DecorrelateLateralJoin { + #[allow(missing_docs)] + pub fn new() -> Self { + Self::default() + } +} + +impl OptimizerRule for DecorrelateLateralJoin { + fn supports_rewrite(&self) -> bool { + true + } + + fn rewrite( + &self, + plan: LogicalPlan, + config: &dyn OptimizerConfig, + ) -> Result<Transformed<LogicalPlan>> { + // Find cross joins with outer column references on the right side (i.e., the apply operator). + let LogicalPlan::Join(join) = &plan else { + return Ok(Transformed::no(plan)); + }; + if join.join_type != JoinType::Inner { + return Ok(Transformed::no(plan)); + } + // TODO: this makes the rule to be quadratic to the number of nodes, in theory, we can build this property Review Comment: https://github.com/apache/datafusion/pull/14595/commits/24a375dc47d830eb0655bb6c4ec699a6b61a623a I decided to use `TreeNodeRecursion::Jump` to skip all children to make it O(n). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
