alamb commented on PR #14671: URL: https://github.com/apache/datafusion/pull/14671#issuecomment-2660990592
> @alamb any Idea on what to do with unit tests in `physical-plan`? I cant think of anything except pulling functions that depend on the component that I moved, to `core_integration` tests or maybe to `datasource` crate. is there a better method? I looked at the errors, and most of them appear to be related to the tests in physical_plan using `MemoryExec` (well now DataSource with a MemoryExec). Some other ideas: 1. Add a `dev-dependency` between datafusion-physical-plan` and `datafusion-datasource` 2. (better) Add a mock `ExecutionPlan` only for testing in `physical_plan` -- this would end up with some amount of duplicate code with DataSourceExec but I think that would be ok for testing. 3. Move the tests, as you say, into tests in `core_integration` or something -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
