Kontinuation commented on PR #14644: URL: https://github.com/apache/datafusion/pull/14644#issuecomment-2659063578
BTW, the 2X amplification for intermediate `Rows` seems to be conservative, but it is still not enough for some of the queries. The following query creates `Rows` larger than the original batches, and the query will fail when reserving memory for `Rows`: ``` -- sort-tpch Q5: 3 sort keys {(INTEGER, 7), (BIGINT, 10k), (BIGINT, 1.5M)} + no payload column SELECT l_linenumber, l_suppkey, l_orderkey FROM lineitem ORDER BY l_linenumber, l_suppkey, l_orderkey ``` This can be worked around by configuring a larger `sort_spill_reservation_bytes`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org