Kontinuation commented on code in PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#discussion_r1954497832
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -369,7 +356,7 @@ impl ExternalSorter {
.with_metrics(self.metrics.baseline.clone())
.with_batch_size(self.batch_size)
.with_fetch(self.fetch)
- .with_reservation(self.reservation.new_empty())
+ .with_reservation(self.merge_reservation.new_empty())
Review Comment:
I believe we should use `merge_reservation` here, because the allocations in
the stream built here are for merging.
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -369,7 +356,7 @@ impl ExternalSorter {
.with_metrics(self.metrics.baseline.clone())
.with_batch_size(self.batch_size)
.with_fetch(self.fetch)
- .with_reservation(self.reservation.new_empty())
+ .with_reservation(self.merge_reservation.new_empty())
Review Comment:
I believe we should use `merge_reservation` here, because the allocations
happening in the stream built here are for merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
