alamb commented on PR #14643: URL: https://github.com/apache/datafusion/pull/14643#issuecomment-2657121490
> do we want `DataSource` trait in `datasource` crate? will that be a breaking change since we won't be able to re-export `DataSource` in `datafusion_physical_plan` without non-trivial refactoring or is it okay to just keep a duplicate code till we release `Datafusion 46.0.0`? To be clear too, I think `DataSource` was added since we released DataFusion 45 https://docs.rs/datafusion/latest/datafusion/index.html?search=DataSource Thus I do't think moving `DataSource` to `datasource` is a breaking API change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
