Omega359 opened a new pull request, #14653: URL: https://github.com/apache/datafusion/pull/14653
## Which issue does this PR close? - Part of #14563, related to https://github.com/apache/datafusion/pull/14636 ``` with_column_10 time: [3.6602 ms 3.8457 ms 4.2130 ms] with_column_100 time: [34.874 ms 35.979 ms 38.018 ms] with_column_200 time: [183.49 ms 187.29 ms 191.65 ms] ``` If there is any dataframe expert here I would love a review of my assumptions. As noted in https://github.com/apache/datafusion/issues/14563#issuecomment-2654798363 > My thinking for the changes in my current branch was that any 'new' Expr (parameter to with_column, with_column_renamed, etc) would go through the normalization, everything else I would like to think would already have been normalized or else how would it be in the DataFrame? What worries me is that I don't know if that assumption is correct or not. ## Rationale for this change Improve performance for with_column and with_column_renamed dataframe functions. ## What changes are included in this PR? Code ## Are these changes tested? Existing tests ## Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
