andygrove commented on PR #1351: URL: https://github.com/apache/datafusion-comet/pull/1351#issuecomment-2655018982
> Question @andygrove @parthchandra @comphead Can any of the child node be decimal calculations? Calling `exprToProtoInternal` will skip `DecimalPrecision.promote()`. I am not sure if it is guaranteed not to have decimal calculations `exprToProto` transforms the entire plan to call `DecimalPrecision.promote()` on each node. After that, it is safe to recurse down using `exprToProtoInternal` only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
