parthchandra commented on code in PR #1387:
URL: https://github.com/apache/datafusion-comet/pull/1387#discussion_r1952694138
##########
native/core/src/parquet/parquet_support.rs:
##########
@@ -596,7 +595,10 @@ fn cast_array(
parquet_options: &SparkParquetOptions,
) -> DataFusionResult<ArrayRef> {
use DataType::*;
- let array = array_with_timezone(array, parquet_options.timezone.clone(),
Some(to_type))?;
+ let array = match to_type {
+ Timestamp(_, None) => array, // array_with_timezone does not support
to_type of NTZ.
Review Comment:
`utils.rs` timezone functions are intended for use by `cast` and
specifically convert between Spark representation and Arrow representation.
Changing them is likely to break some timezone related unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
