mbutrovich commented on code in PR #1387:
URL: https://github.com/apache/datafusion-comet/pull/1387#discussion_r1952625044
##########
native/core/src/parquet/parquet_support.rs:
##########
@@ -596,7 +595,10 @@ fn cast_array(
parquet_options: &SparkParquetOptions,
) -> DataFusionResult<ArrayRef> {
use DataType::*;
- let array = array_with_timezone(array, parquet_options.timezone.clone(),
Some(to_type))?;
+ let array = match to_type {
+ Timestamp(_, None) => array, // array_with_timezone does not support
to_type of NTZ.
Review Comment:
Yeah, it shouldn't be called with that type:
https://github.com/apache/datafusion-comet/blob/f099e6e40aa18441c7882e5bffd9d6dfb10c6c19/native/spark-expr/src/utils.rs#L59
The condition that matches inside `array_with_timezone` was added by #1348...
https://github.com/apache/datafusion-comet/blob/f099e6e40aa18441c7882e5bffd9d6dfb10c6c19/native/spark-expr/src/utils.rs#L76
...and we likely didn't understand the blast radius at the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
