logan-keede commented on PR #14616: URL: https://github.com/apache/datafusion/pull/14616#issuecomment-2652876201
> Why not move to the `datasource` crate but `catalog-listing` original plan was to move just `datasource::listing` to `catalog-listing`, but `listing/table.rs` has some dependencies on 'these' files (almost all file with pattern "physical_plan/file_\*.rs" or "file_format/file_*.rs") but 'these' files also have some dependency on `catalog-listing` (like `PartitionedFile` and more). So, this was all I could think of to avoid circular dependency and keeping original structure somewhat intact. do you still think we can make a `datasource` crate distinct from `catalog-listing`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
