logan-keede commented on code in PR #14616: URL: https://github.com/apache/datafusion/pull/14616#discussion_r1952101752
########## datafusion/core/src/datasource/physical_plan/csv.rs: ########## @@ -28,8 +28,8 @@ use crate::datasource::data_source::FileSource; use crate::datasource::file_format::file_compression_type::FileCompressionType; use crate::datasource::file_format::{deserialize_stream, DecoderDeserializer}; use crate::datasource::listing::{FileRange, ListingTableUrl, PartitionedFile}; -use crate::datasource::physical_plan::file_stream::{FileOpenFuture, FileOpener}; use crate::datasource::physical_plan::FileMeta; +use crate::datasource::physical_plan::{FileOpenFuture, FileOpener}; Review Comment: They are already in physical_plan. They could be imported from both `file_stream` and `physical_plan` earlier. https://github.com/apache/datafusion/blob/abb7669098a546c9368f60f752dfa71cdcb99a6d/datafusion/core/src/datasource/physical_plan/mod.rs#L58 or did I misunderstand something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org