wForget commented on code in PR #1379:
URL: https://github.com/apache/datafusion-comet/pull/1379#discussion_r1951893497
##########
spark/src/main/scala/org/apache/spark/Plugins.scala:
##########
@@ -62,7 +62,13 @@ class CometDriverPlugin extends DriverPlugin with Logging
with ShimCometDriverPl
Math.max((executorMemory * memoryOverheadFactor).toLong,
memoryOverheadMinMib)
}
- val cometMemOverhead =
CometSparkSessionExtensions.getCometMemoryOverheadInMiB(sc.getConf)
+ val cometMemOverhead =
+ if
(!CometSparkSessionExtensions.cometUnifiedMemoryManagerEnabled(sc.getConf)) {
+ CometSparkSessionExtensions.getCometMemoryOverheadInMiB(sc.getConf)
Review Comment:
Yes, the purpose here is to override executor overhead memory, and we don't
need to override it when we use a unified memory manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
