simonvandel commented on code in PR #14593:
URL: https://github.com/apache/datafusion/pull/14593#discussion_r1951592139
##########
datafusion/functions/src/datetime/date_trunc.rs:
##########
@@ -185,10 +185,10 @@ impl ScalarUDFImpl for DateTruncFunc {
) -> Result<ColumnarValue> {
let parsed_tz = parse_tz(tz_opt)?;
let array = as_primitive_array::<T>(array)?;
- let array = array
- .iter()
- .map(|x| general_date_trunc(T::UNIT, &x, parsed_tz,
granularity.as_str()))
- .collect::<Result<PrimitiveArray<T>>>()?
+ let array: PrimitiveArray<T> = array
+ .try_unary(|x| {
+ general_date_trunc(T::UNIT, x, parsed_tz,
granularity.as_str())
Review Comment:
I can take a look at that. Would it be okay to do so in another PR?
Then we have the benchmark on main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
