davidhewitt commented on code in PR #14602:
URL: https://github.com/apache/datafusion/pull/14602#discussion_r1950573621
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -537,8 +537,15 @@ fn type_union_resolution_coercion(
}
(DataType::Dictionary(index_type, value_type), other_type)
| (other_type, DataType::Dictionary(index_type, value_type)) => {
- let new_value_type = type_union_resolution_coercion(value_type,
other_type);
- new_value_type.map(|t| DataType::Dictionary(index_type.clone(),
Box::new(t)))
+ match type_union_resolution_coercion(value_type, other_type) {
+ // Dict(k, Utf8View) is redundant, Utf8View is good enough
+ Some(DataType::Utf8View) => Some(DataType::Utf8View),
Review Comment:
Possibly also true for binary views (even if I didn't report in my original
issue)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
