eliaperantoni commented on issue #14433: URL: https://github.com/apache/datafusion/issues/14433#issuecomment-2650017992
> @eliaperantoni thank you so much for the detailed explanation! Since `Expr::Negative` and `Expr::Not` just wraps another `Expr`, does it mean that I need to make span available on all of the cases in order to make them work? For a perfect implementation, yes that would be necessary. But that goes well beyond the scope of this ticket. I think it's perfectly fine if, in the case of `Expr::Negative` and `Expr::Not` and similar, you call `spans` recursively. This will already make it work in a lot of common cases like `Not(Column)` (e.g. `SELECT NOT is_admin`) or `Negative(Column)` (e.g. `SELECT -score AS loss`). And then a more extensive implementation of `Expr::spans` will slowly come along as more tickets are implemented, and unary expressions would be future-proof because you make a recursive call :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
