peter-toth commented on PR #13046: URL: https://github.com/apache/datafusion/pull/13046#issuecomment-2646358282
@andygrove , I've updated the PR from `main`. Please note that the new `EliminateCommonPhysicalSubexprs` rule is not part of the default `PhysicalOptimizer` as the rule has no use in standard DataFusion. If you would like to use this rule in Comet then you explicitely need to add the rule the optimizer. Also, this is a simplified version of the logical rule, it handles `ProjectExec` nodes only and doesn't normalize expressions during elimination (e.g. `ProjectExec [a + 1, 1 + a]` will not be eliminated for now). But if you think the rule is useful I'm happy to port all the features of the logical rule. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
