alamb commented on code in PR #14558:
URL: https://github.com/apache/datafusion/pull/14558#discussion_r1948061227
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -974,6 +974,129 @@ impl ScalarValue {
)
}
+ /// Create a Null instance of ScalarValue for this datatype
+ ///
+ /// Example
+ /// ```
+ /// use datafusion_common::ScalarValue;
+ /// use arrow::datatypes::DataType;
+ ///
+ /// let scalar = ScalarValue::try_new_null(&DataType::Int32).unwrap();
+ /// assert_eq!(scalar.is_null(), true);
+ /// assert_eq!(scalar.data_type(), DataType::Int32);
+ /// ```
+ pub fn try_new_null(data_type: &DataType) -> Result<Self> {
Review Comment:
Thank you @cj-zhukov 🙏
I think this duplicates much of the code in the `TryFrom` impl -- can you
please change `TryFrom` to call this new function to avoid the duplication?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
