alamb commented on PR #14411:
URL: https://github.com/apache/datafusion/pull/14411#issuecomment-2640829028

   > This is still in somewhat early stages, and there is work to do. But it 
might be good to get feedback early on from the community as the performance of 
this code is somewhat sensitive to idioms used with channels etc.
   
   Maybe I am missing something, but the benchmark numbers reported above don't 
really show much of an improvement
   
   For example, this branch appears to be basically the same
   ```
   │ Total Time (main)                                │ 11767.43ms │
   │ Total Time (on-demand-repartition-with-config)   │ 11787.12ms │
   ```
   
   Are there any benchmarks that show a performance benefit of all this new 
code?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to