jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1944757020
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -455,6 +461,46 @@ fn get_data_types(native_type: &NativeType) ->
Vec<DataType> {
}
}
+#[derive(Debug, Clone)]
+pub struct FunctionSignature {
+ pub parameters: Vec<ParameterSignature>,
+ /// The volatility of the function. See [Volatility] for more information.
+ pub volatility: Volatility,
+}
+
+pub type ParameterSignature = Vec<ParameterType>;
+
+#[derive(Debug, Clone, Eq, PartialOrd, Hash)]
+pub struct ParameterType {
+ pub param_type: LogicalTypeRef,
Review Comment:
I would like to have a breaking change to `Signature::Coercible` too, the
only concern is whether this cause regression or large impact to downstream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
