jayzhan211 commented on code in PR #14268:
URL: https://github.com/apache/datafusion/pull/14268#discussion_r1944640302
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -213,9 +221,8 @@ pub enum TypeSignatureClass {
Interval,
Duration,
Native(LogicalTypeRef),
- // TODO:
- // Numeric
- // Integer
+ Numeric(LogicalTypeRef),
+ Integer(LogicalTypeRef),
Review Comment:
@shehabgamin I found that we might not need `LogicalTypeRef`.
This is designed to accept all the Integer, so if the given type is integer,
we keep it as it is.
If we want specific integer type, then we should use Native instead. Does
this makes sense to you?
Numeric is the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
