ozankabak commented on PR #14224: URL: https://github.com/apache/datafusion/pull/14224#issuecomment-2639597492
> @alamb The FileType enum was forgotten, I deleted it completely and returned just a &str for file_type() Great - custom source creators will just implement some `MyCoolFormatSource` just like `ParquetSource` implements `FileSource`. No need for hardcoded enums or another level of traits. They inform the overall mechanism of their file type extension by simply overriding the `file_type` method. --- I think we addressed all the feedback and made the PR even better. Migration path is simple, and two major downstream projects took a pass on it. Let's wait for a few hours in case anything else comes in, and then proceed with the merge. @alamb, can you take a final look to verify all is good? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
