mbutrovich commented on code in PR #1329:
URL: https://github.com/apache/datafusion-comet/pull/1329#discussion_r1944106936
##########
native/core/src/execution/jni_api.rs:
##########
@@ -233,11 +242,12 @@ pub unsafe extern "system" fn
Java_org_apache_comet_Native_createPlan(
stream: None,
runtime,
metrics,
+ metrics_update_interval,
+ metrics_last_update_time: Instant::now(),
Review Comment:
https://github.com/jedisct1/rust-coarsetime
@andygrove thoughts on a coarse time crate? The overhead on these
clock_gettime() as used underneath Instant::now() can really add up. Maybe it's
a premature optimization, but I also don't want a "death by 1000 cuts" scenario
with gettime() all over the place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
