eliaperantoni commented on code in PR #14439:
URL: https://github.com/apache/datafusion/pull/14439#discussion_r1943779212
##########
datafusion/sql/src/select.rs:
##########
@@ -574,10 +574,19 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
empty_from: bool,
planner_context: &mut PlannerContext,
) -> Result<Vec<Expr>> {
- projection
- .into_iter()
- .map(|expr| self.sql_select_to_rex(expr, plan, empty_from,
planner_context))
- .collect::<Result<Vec<Expr>>>()
+ let mut prepared_select_exprs = vec![];
+ let mut errors = vec![];
+ for expr in projection {
+ match self.sql_select_to_rex(expr, plan, empty_from,
planner_context) {
+ Ok(expr) => prepared_select_exprs.push(expr),
+ Err(err) => errors.push(err),
+ }
+ }
+ if !errors.is_empty() {
Review Comment:
Ah yes good point! I like that, will change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
