alamb commented on issue #13983: URL: https://github.com/apache/datafusion/issues/13983#issuecomment-2633683712
> If this looks ok, I can create a PR on clickbench to update the results First of all, thank you so much @pmcgleenon -- this is super helpful as always 🙏 I looked at the results and they are inline with my expectations. Specifically most of the major improvements mirror the improvement made by @jayzhan211 https://github.com/apache/datafusion/pull/12996 (they are similar improvements as reported in https://github.com/apache/datafusion/pull/12996#issuecomment-2457985415) There are a few queries that appear to have gotten slower (q36 and q37) https://github.com/apache/datafusion/blob/0d9f845a243ed90abe472e89b84a3cb5a8e681c2/benchmarks/queries/clickbench/queries.sql#L37-L38 I will file a separate ticket for looking into them. But from my perspective these results are ready to go 🚀 (BTW I expect DataFusion `45.0.0` to be available in the next few days -- see https://github.com/apache/datafusion/issues/14008 -- and it has yet more improvements!) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
