berkaysynnada commented on PR #13511: URL: https://github.com/apache/datafusion/pull/13511#issuecomment-2633502146
Thank you @Garamda, the code is well-written and has a good documentation. I couldn't fully think on the details of the implementation, but as an early review, I can suggest adding new tests instead of changing the existing ones, and you should revert the submodule changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
