mertak-synnada commented on code in PR #14224:
URL: https://github.com/apache/datafusion/pull/14224#discussion_r1940573217
##########
datafusion/core/src/datasource/physical_plan/file_scan_config.rs:
##########
@@ -156,6 +161,8 @@ impl FileScanConfig {
limit: None,
table_partition_cols: vec![],
output_ordering: vec![],
+ file_compression_type: FileCompressionType::UNCOMPRESSED,
+ new_lines_in_values: false,
Review Comment:
Yes, these are only common in CSV and JSON but since their defaults are not
affecting I thought we could add them in the common area to avoid code
duplication, but if it feels wrong for more possible file types, we can remove
them from here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
