iffyio commented on code in PR #1689:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1689#discussion_r1938890850
##########
src/ast/mod.rs:
##########
@@ -5912,6 +5924,7 @@ impl fmt::Display for GrantObjects {
display_comma_separated(schemas)
)
}
+ GrantObjects::None => Ok(()),
Review Comment:
Can we instead make `GrantObjects` optional at the usage sites that require
it? i.e. `objects: Option<GrantObjects>`. Thinking so that we get the None
representation by convention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
