alamb commented on code in PR #14371:
URL: https://github.com/apache/datafusion/pull/14371#discussion_r1938310453


##########
datafusion/common/src/error.rs:
##########
@@ -131,6 +131,10 @@ pub enum DataFusionError {
     /// Errors from either mapping LogicalPlans to/from Substrait plans
     /// or serializing/deserializing protobytes to Substrait plans
     Substrait(String),
+
+    /// Errors for wrapping other errors.

Review Comment:
   Why is this needed (compared to `Context` for example?) I don't understand 
why we need to keep the data wrappeed (why don't we just pass the underlying 
error back?)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to