parthchandra commented on code in PR #1364:
URL: https://github.com/apache/datafusion-comet/pull/1364#discussion_r1938143154
##########
native/Cargo.toml:
##########
@@ -39,15 +39,15 @@ arrow-buffer = { version = "54.0.0" }
arrow-data = { version = "54.0.0" }
arrow-schema = { version = "54.0.0" }
parquet = { version = "54.0.0", default-features = false, features =
["experimental"] }
-datafusion = { git = "https://github.com/apache/datafusion";, rev = "5592834",
default-features = false, features = ["unicode_expressions",
"crypto_expressions"] }
-datafusion-common = { git = "https://github.com/apache/datafusion";, rev =
"5592834", default-features = false }
-datafusion-functions = { git = "https://github.com/apache/datafusion";, rev =
"5592834", default-features = false, features = ["crypto_expressions"] }
-datafusion-functions-nested = { git = "https://github.com/apache/datafusion";,
rev = "5592834", default-features = false }
-datafusion-expr = { git = "https://github.com/apache/datafusion";, rev =
"5592834", default-features = false }
-datafusion-expr-common = { git = "https://github.com/apache/datafusion";, rev =
"5592834", default-features = false }
-datafusion-execution = { git = "https://github.com/apache/datafusion";, rev =
"5592834", default-features = false }
-datafusion-physical-plan = { git = "https://github.com/apache/datafusion";, rev
= "5592834", default-features = false }
-datafusion-physical-expr = { git = "https://github.com/apache/datafusion";, rev
= "5592834", default-features = false }
+datafusion = { git = "https://github.com/apache/datafusion";, rev = "8d006a2",
default-features = false, features = ["unicode_expressions",
"crypto_expressions"] }
Review Comment:
For my edification, is there a reason why we have to use a git revision. Is
this not published to a public repository?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
