alamb commented on issue #5600: URL: https://github.com/apache/datafusion/issues/5600#issuecomment-2628502728
> @alamb just making sure if I understand, CI will still run and check datafusion/src/functions-spark even it is not a dependency? Yes that is my assumption > For example, testing interface changes that affects both datafusion/src/functions-spark and datafusion/core Yes that is what I was thinking. Exactly what those tests would be I am not 100% sure (e.g. there probably needs to be some way to test them without actually running spark > > My assumption is this is a totally optional feature for downstream projects (core dependencies do not change). > > Correct. It is part of the workspace, but no other DataFusion crates depend on it. > > Perhaps there is an argument for datafusion-cli having an optional dependency on it in the future. 100% -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
