kazuyukitanimura commented on issue #5600: URL: https://github.com/apache/datafusion/issues/5600#issuecomment-2628231531
+1 for including spark functions in DataFusion main > Do not add a dependency on datafusion crate (datafusion/core) @alamb just making sure if I understand, CI will still run and check `datafusion/src/functions-spark` even it is not a dependency? For example, testing interface changes that affects both `datafusion/src/functions-spark` and `datafusion/core` Sounds like so based on your follow up comment > In terms of testing, I think some combination of sqllogictest / gold data style tests and maybe even real-spark runs in the [extended.yml](https://github.com/apache/datafusion/blob/5113386a35a71f442b1593b48710f4758bcb0d47/.github/workflows/extended.yml#L4) suite (see XXX that @Omega359 made recently) could minimize CI overhead but still make sure the functions worked in spark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
