adriangb commented on PR #14362: URL: https://github.com/apache/datafusion/pull/14362#issuecomment-2628399078
Makes sense. I *think* I've gotten all of the important cases here working, could you take a look at the tests and see if you are happy with them? I will note that if we drop just *one* of the requirements from Spark, namely the resolution of name conflicts in favor of non-system columns, the whole thing becomes a lot simpler: hiding system columns from `SELECT *` is not that difficult, but overriding how name collisions are resolved in the many places they can happen is a lot more involved. Although I think I did it correctly in this PR I fear that the extent of the modification to the rest of the codebase and risk of things falling through the cracks in the future (e.g. if someone adds a new join type or otherwise does more invasive work of their own) is higher than the other part of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
