findepi commented on code in PR #14366:
URL: https://github.com/apache/datafusion/pull/14366#discussion_r1934669162
##########
datafusion/expr/src/expr.rs:
##########
@@ -3067,4 +3078,19 @@ mod test {
rename: opt_rename,
}
}
+
+ #[test]
+ fn test_size_of_expr() {
+ // because Expr is such a widely used struct in DataFusion
+ // it is important to keep its size as small as possible
+ //
+ // If this test fails when you change `Expr`, please try
+ // `Box`ing the fields to make `Expr` smaller
+ // See https://github.com/apache/datafusion/issues/14256 for details
+ assert_eq!(size_of::<Expr>(), 112);
+ assert_eq!(size_of::<ScalarValue>(), 64);
+ assert_eq!(size_of::<DataType>(), 24); // 3 ptrs
Review Comment:
does this test pass in debug and release modes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
