findepi commented on issue #14296: URL: https://github.com/apache/datafusion/issues/14296#issuecomment-2622375940
I am OK having user-defined coercion rules as long as they are applied reasonably in the DataFusion core. In particular, the coercion rules should be applied by the analyzer, during the logical plan construction. The optimizers should never perform any coercions. Period. In particular, for DataFusion usage as a library in a system like ~SDF~ dbt compiler, where frontend is separate and DataFusion is handed over fully resolved logical plan nodes, the DF core should not invoke any coercion-related logic during plan optimizations or query processing. This is substantial for DataFusion to be a reliable building block for other systems (https://github.com/apache/datafusion/issues/12723). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
