logan-keede commented on issue #13351: URL: https://github.com/apache/datafusion/issues/13351#issuecomment-2621744869
> That is a very good question. There must have been I reason I didn't do that when I coded this up but right now I can't recall why it would have been. Let me think about that for a day and see if I can recall a good reason. I think I found the reason, According to documentation >`Optional Chrono format strings to use to parse the expression. Formats will be tried in the order they appear with the first successful one being returned. If none of the formats successfully parse the expression an error will be returned.` So, even if a format is wrong it should not throw error till it has tried all the formats and if it does then it just gives error ` no format matches`. So, I think we should leave that as it is, however if we really want to improve UX we can generate a warning, that `xyz` is not a valid chrono format. Let me know if that makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
