chenkovsky commented on PR #14057:
URL: https://github.com/apache/datafusion/pull/14057#issuecomment-2620712360
> > sorry @jayzhan211 I edited my comment above after you reacted to it I
think, I felt bad about requesting an explainer when there was already a thread
with details
>
> Maybe we can think about whether changing the `metadata` in `Field` makes
sense
>
> ```rust
> pub struct Field {
> name: String,
> data_type: DataType,
> nullable: bool,
> dict_id: i64,
> dict_is_ordered: bool,
> /// A map of key-value pairs containing additional custom meta data.
> metadata: HashMap<String, String>,
> }
>
> Field.metadata['is_system_generated'] = 'true'
> ```
If we use hashmap to store this flag. Then we cannot make sure metadata
columns always have same column index in different tables. I don't know whether
it's important. but I think it makes something easy.
for example, when we want to use metadata column somewhere other than
datafusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
