andygrove commented on code in PR #1321:
URL: https://github.com/apache/datafusion-comet/pull/1321#discussion_r1931284776
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2428,6 +2428,22 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
withInfo(expr, "unsupported arguments for ArrayJoin", exprs: _*)
None
}
+ case expr @ ArrayFilter(child, _) if ArrayCompact(child).replacement.sql
== expr.sql =>
Review Comment:
Because the PR only contains basic tests, could you add a check to enable
this expression only if `CometConf.COMET_CAST_ALLOW_INCOMPATIBLE` is enabled?
We can remove this check in a future PR that adds comprehensive tests and
demonstrates that we have Spark-compatible behavior for all supported data
types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
