wiedld commented on code in PR #14329:
URL: https://github.com/apache/datafusion/pull/14329#discussion_r1931100366
##########
datafusion/core/tests/user_defined/user_defined_plan.rs:
##########
@@ -295,20 +296,175 @@ async fn topk_plan() -> Result<()> {
Ok(())
}
+#[tokio::test]
+/// Run invariant checks on the logical plan extension [`TopKPlanNode`].
+async fn topk_invariants() -> Result<()> {
+ // Test: pass an InvariantLevel::Always
+ let pass = InvariantMock {
+ should_fail_invariant: false,
+ kind: InvariantLevel::Always,
+ };
+ let ctx =
setup_table(make_topk_context_with_invariants(Some(pass))).await?;
+ run_and_compare_query(ctx, "Topk context").await?;
+
+ // Test: fail an InvariantLevel::Always
+ let fail = InvariantMock {
+ should_fail_invariant: true,
+ kind: InvariantLevel::Always,
+ };
+ let ctx =
setup_table(make_topk_context_with_invariants(Some(fail))).await?;
+ matches!(
+ &*run_and_compare_query(ctx, "Topk context")
+ .await
+ .unwrap_err()
+ .message(),
+ "node fails check, such as improper inputs"
+ );
+
+ // Test: pass an InvariantLevel::Executable
+ let pass = InvariantMock {
+ should_fail_invariant: false,
+ kind: InvariantLevel::Executable,
+ };
+ let ctx =
setup_table(make_topk_context_with_invariants(Some(pass))).await?;
+ run_and_compare_query(ctx, "Topk context").await?;
+
+ // Test: fail an InvariantLevel::Executable
+ let fail = InvariantMock {
+ should_fail_invariant: true,
+ kind: InvariantLevel::Executable,
+ };
+ let ctx =
setup_table(make_topk_context_with_invariants(Some(fail))).await?;
+ matches!(
+ &*run_and_compare_query(ctx, "Topk context")
+ .await
+ .unwrap_err()
+ .message(),
+ "node fails check, such as improper inputs"
+ );
+
+ Ok(())
+}
+
+#[tokio::test]
+async fn topk_invariants_after_invalid_mutation() -> Result<()> {
Review Comment:
test: demonstrate a failed invariant check after logical plan mutation
(during optimizer run).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
