berkaysynnada commented on issue #14243: URL: https://github.com/apache/datafusion/issues/14243#issuecomment-2609479704
> I've an idea. You're moving all tests to core/physical_optimizer with [#14244](https://github.com/apache/datafusion/pull/14244). So, as of now, if we are writing tests core/physical_optimizer for physical optimizers, then datafusion/physical_optimizer/test_utils.rs can also be moved to core/physical_optimizer, and that will remove this dep. WDYT? If it sounds good, let's put all others (join_selection, limit-pushdown and more if there are) and test_utils into that PR. I can do that BTW if you are okay, and then work on https://github.com/apache/datafusion/pull/14235/files, and finally delete the core/physical_optimizer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
