graup commented on issue #1673:
URL:
https://github.com/apache/datafusion-sqlparser-rs/issues/1673#issuecomment-2609359758
The issue here is that `parse_literal_string` which is used by `TypedString`
doesn't support quote styles other than single or double quoted strings.
Trying to fix this I came across two related issues:
- currently `TypedString` doesn't retain any knowledge about the used quote
style, so it doesn't roundtrip properly. It always formats as a single quoted
string.
- We can fix this by making `TypedString` contain a `Value` instead of a
`String`. This also gives us support for other quote styles, addressing the
issue reported here.
- `fmt::Display for EscapeQuotedString` doesn't take into account the
dialect, producing strings like `'foo''bar'` which is invalid in BQ (should be
`'foo\'bar'`). So something like this `SELECT JSON "{\"foo\":\"bar's\"}"`
currently also doesn't get formatted correctly
- Not sure how to fix this one, seems a bit more involved.
I'll push a PR addressing this in a moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
