alamb commented on code in PR #14175:
URL: https://github.com/apache/datafusion/pull/14175#discussion_r1921114939
##########
datafusion/common/src/config.rs:
##########
@@ -467,6 +472,7 @@ config_namespace! {
/// (writing) Sets max statistics size for any column. If NULL, uses
/// default parquet writer setting
+ #[allow(deprecated)]
Review Comment:
It hink the idea is to mark this as deprecated (not mark it as allowed
deprecated)
Like
```suggestion
#[deprecated(since = "45.0.0", note = "Setting does not do
anything")]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
