mnpw commented on PR #14083:
URL: https://github.com/apache/datafusion/pull/14083#issuecomment-2593062436
@alamb
Here's my understanding of the issue:
- `datafusion` crate already depends on `datafusion-physical-optimizer`.
- SanityChecker's tests depend on `datafusion::datasources::{listing,
physical_plan, stream}` (via `datafusion::physical_optimizer::test_utils`).
- Moving SanityChecker, with its tests, to `datafusion-physical-optimizer`
makes `datafusion-physical-optimizer` depend on `datafusion::datasources`.
- This creates a circular dependency between `datafusion` and
`datafusion-physical-optimizer`.
In this case, best solution seems to be to move SanityChecker to
`datafusion-physical-optimizer` while keeping its tests in
`datafusion/core/tests`.
I have re-worked the PR and made the following changes:
- Move SanityChecker to `datafusion-physical-optimizer`
- Move SanityChecker's tests to `datafusion/core/tests`
- Move independent componenets from
`datafusion::physical_optimizer::test_utils` to
`datafusion-physical-optimizer::test_utils`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
