alamb commented on PR #14083: URL: https://github.com/apache/datafusion/pull/14083#issuecomment-2585346810
> I don't like that datafusion-physical-optimizer needs to use datafusion crate as a dev-dependency. Thanks @mnpw -- I agree this is not good and we shouldn't merge it in like that (and in fact I think it failed the circular dependency check) I think one of the major sources of this dependency is the use of `ParquetExec` which is still defined in the core module... Since `datafusion` already depends on `phsyical-optimizer`, what would you think about moving as many of the physical optimizer utils from * https://github.com/apache/datafusion/blob/main/datafusion/core/src/physical_optimizer/test_utils.rs To * https://github.com/apache/datafusion/tree/main/datafusion/physical-optimizer/src/test_utils.rs As possible? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
