alamb commented on code in PR #13986:
URL: https://github.com/apache/datafusion/pull/13986#discussion_r1914720254
##########
datafusion/physical-optimizer/src/optimizer.rs:
##########
@@ -46,4 +46,23 @@ pub trait PhysicalOptimizerRule: Debug {
/// Some of the optimization rules might change the nullable properties of
the schema
/// and should disable the schema check.
fn schema_check(&self) -> bool;
+
+ /// A flag to indicate whether the PhysicalOptimizerRule is
+ /// expected to produce an executable physical plan as output,
Review Comment:
Is there any definition of what "Executable" means for a physical plan?
I thought the point of this PR was to start defining what invariants existed
for physical plans, not for optimizer passes 🤔
I think as written this API is more confusing than helpful.
I am imagining myself as a user who sees this method. How would i ever know
when to implement it? Why would I prefer this API to simply verifying whatever
checks I wanted in `PhysicalOptimizerRule::optimize`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
