alamb commented on PR #14057: URL: https://github.com/apache/datafusion/pull/14057#issuecomment-2586885945
FWIW I ran the planning benchmarks on this branch and see no measurable difference. ✅ ``` ++ critcmp main feature_metadata_columns group feature_metadata_columns main ----- ------------------------ ---- logical_select_all_from_1000 1.00 5.2±0.03ms ? ?/sec 1.01 5.3±0.04ms ? ?/sec physical_plan_clickbench_all 1.00 226.7±1.82ms ? ?/sec 1.00 227.1±1.40ms ? ?/sec physical_plan_tpcds_all 1.00 1380.0±3.29ms ? ?/sec 1.00 1378.8±5.32ms ? ?/sec physical_plan_tpch_all 1.00 90.2±0.70ms ? ?/sec 1.01 91.1±1.32ms ? ?/sec physical_select_all_from_1000 1.02 42.4±0.30ms ? ?/sec 1.00 41.5±0.16ms ? ?/sec ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org