iffyio commented on code in PR #1628:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1628#discussion_r1909594021
##########
src/ast/dml.rs:
##########
@@ -547,7 +561,15 @@ impl Display for Insert {
write!(f, "{source}")?;
}
- if self.source.is_none() && self.columns.is_empty() {
+ if let Some(settings) = &self.settings {
+ write!(f, "SETTINGS {} ", display_comma_separated(settings))?;
+ }
+
+ if let Some(format_clause) = &self.format_clause {
+ write!(f, "{format_clause}")?;
+ }
+
+ if self.source.is_none() && self.columns.is_empty() &&
self.format_clause.is_none() {
Review Comment:
Ah I see, hmm the logic for that `self.columns.is_empty()` seems flawed
since that condition doesn't imply `DEFAULT VALUES` but that's unrelated to
this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
