alamb commented on PR #14028: URL: https://github.com/apache/datafusion/pull/14028#issuecomment-2580367825
> Would a test case like this one be useful? [influxdata@b9e4d8b](https://github.com/influxdata/arrow-datafusion/commit/b9e4d8b4c64c228dc611981fda98cc7d1b33031d) > > It does capture the difference with, versus without, this change. Thank you @wiedld -- I think this type of test is basically testing the implementation (eg. testing that yielding is happening). However the behavior we care about here is that the stream stops processing when dropped (aka canceled) Thus I agree with @ozankabak that we should get some sort of higher level reproducer to be sure we have fixed the root cause (rather than just treating the symptom) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
