alamb commented on code in PR #14040:
URL: https://github.com/apache/datafusion/pull/14040#discussion_r1906019498
##########
datafusion/physical-expr/src/equivalence/properties.rs:
##########
@@ -124,15 +124,15 @@ use itertools::Itertools;
/// ```
#[derive(Debug, Clone)]
pub struct EquivalenceProperties {
- /// Collection of equivalence classes that store expressions with the same
- /// value.
- pub eq_group: EquivalenceGroup,
- /// Equivalent sort expressions for this table.
- pub oeq_class: OrderingEquivalenceClass,
- /// Expressions whose values are constant throughout the table.
+ /// Distinct equivalence classes (exprs known to have the same expressions)
+ eq_group: EquivalenceGroup,
Review Comment:
here are the changes. I want to make sure that nothing externally can modify
these fields without going through methods on EquivalenceProperties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
