alamb commented on code in PR #14038:
URL: https://github.com/apache/datafusion/pull/14038#discussion_r1905986687
##########
datafusion/physical-expr/src/equivalence/ordering.rs:
##########
@@ -207,19 +212,6 @@ impl IntoIterator for OrderingEquivalenceClass {
}
}
-/// This function constructs a duplicate-free `LexOrdering` by filtering out
Review Comment:
Despite the function being `pub` it appears to be in a non pub module, so is
not exposed. You can see that it is not present in the docs:
https://docs.rs/datafusion/latest/datafusion/index.html?search=collapse_lex_ordering
(when I marked it deprecated then clippy complained it was dead code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
